acts icon indicating copy to clipboard operation
acts copied to clipboard

HepMC plugin looks incomplete

Open andiwand opened this issue 2 years ago • 5 comments

While working on https://github.com/acts-project/acts/pull/2998 I noticed that HepMC plugin is incomplete. It also seems like we are not using or testing the code anywhere in detail.

  • Problem with ownership of Acts particles
    • Currently Acts particles cannot refer to each other and are usually owned by a container holding all particles
    • When introducing vertices this becomes a problem
    • When modeling vertices this becomes a problem
  • Conversion is incomplete
    • The Acts barcode is not properly filled
  • Code is not used
  • Code is not properly tested

andiwand avatar Mar 22 '24 09:03 andiwand

@paulgessinger: The plugin is quite old and was used by @FabianKlimpel in 2018 for testing. Maybe there was an EDM mismatch, that Fabian tried to work around. It seems like something useful to have, but needs some work.

Please someone work on it, because it is cool. Maybe @andiwand ?

AJPfleger avatar Mar 26 '24 08:03 AJPfleger

I fear I won't have time to work on this.

andiwand avatar Mar 26 '24 09:03 andiwand

I think I just used it for the parametrisation of hadronic interactions in Fatras. So just for a limited scope and period of time. Hence I can imangine that something went out of sync with Acts. If you want to continue using it, I recommend to ping @andriish as he is one of the HepMC developers and helped me out during the development.

FabianKlimpel avatar Mar 26 '24 16:03 FabianKlimpel

Hi, the barcode should be used carefully or should not be used at all. Concerning other things i will be happy to help.

andriish avatar Mar 27 '24 12:03 andriish

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

github-actions[bot] avatar Apr 26 '24 12:04 github-actions[bot]