elementium icon indicating copy to clipboard operation
elementium copied to clipboard

Configurable Selenium version

Open evkostadinov opened this issue 7 years ago • 5 comments

Currently the Selenium version is locked to 2.48, but some users would like to integrate Elementium to their own setup and versions. In my case:

elementium 1.1.10 has requirement selenium==2.48.0, but you'll have selenium 3.0.2 which is incompatible.

I would be happy to try and implement the needed changes, after a discussion @prschmid.

evkostadinov avatar May 14 '18 06:05 evkostadinov

I unfortunately haven't looked at the new version of selenium. How different are things?

Would it be possible to do something like (please excuse the bad pseudocode)

SeElements = {
  '2': lambda: SeElements2
  '3': lambda: SeElements3
}[get_selenium_driver_version()]

class SeElements2(object)
    """The implementation compatible with selenium drive 2.x"""

class SeElements3(object)
    """The implementation compatible with selenium drive 3.x"""

prschmid avatar May 21 '18 22:05 prschmid

I'm using elementium with Selenium 3.02 in the past month and works like a charm. There are no issues, that are stopping us from simply updating to newer version (ref. Selenium CHANGELOG). The suggested mapping changes could work.

ekostadinov avatar Jun 04 '18 06:06 ekostadinov

@ekostadinov @evkostadinov I apologize for not addressing this in the past year! Do either of you want to take another look at this issue and propose a change?

prschmid avatar May 21 '19 17:05 prschmid

Although I haven't pushed it to pypi, I have updated the dependencies for selenium to 3.141.0. I'm guessing that enough time has passed and most people are on 3 now. If you want to check that out to make sure it works for you, that'll be great. I'll likely push the changes to pypi at some point in the near future.

prschmid avatar Sep 30 '19 22:09 prschmid

@prschmid any chance for a push of the latest selenium dependency to pypi as well? It has been a while since selenium is out and from I have seen it works without issues with a custom version installed

Adrian-Tamas avatar May 31 '22 07:05 Adrian-Tamas