setup-node icon indicating copy to clipboard operation
setup-node copied to clipboard

Add lts alias for lts/*

Open zdm opened this issue 1 year ago • 5 comments

Description: Could you please add simple lts alias for the latest lts version in addition to the lts/*? lts/* is not obvious, ugly and confusing.

If ypu don't want to do this - please, close this issue immediately,

zdm avatar Apr 03 '24 21:04 zdm

Hello @zdm Thank you for creating this feature request. We will investigate it and get back to you as soon as we have some feedback.

HarithaVattikuti avatar Apr 04 '24 22:04 HarithaVattikuti

oh wow! That's exactly how I reached here. So following the official doc page:

- uses: actions/setup-node@v4
  with:
    # Version Spec of the version to use in SemVer notation.
    # It also admits such aliases as lts, latest, nightly and canary builds
    # Examples: 12.x, 10.15.1, >=10.15.0, lts/Hydrogen, 16-nightly, latest, node
    node-version: ''

we can see It also admits such aliases as lts

but this is what we get in real:

Run actions/setup-node@v4
  with:
    node-version: lts
    registry-url: https://registry.npmjs.org/
    always-auth: false
    check-latest: false
    token: ***
Attempting to download lts...
Not found in manifest. Falling back to download directly from Node

ThePlenkov avatar Aug 29 '24 12:08 ThePlenkov

@ThePlenkov's experience is exactly how I ended up here as well. An lts alias would be great, but at a minimum the docs should be updated to be more clear.

voldemortensen avatar Sep 10 '24 15:09 voldemortensen

Same feedback: the lts alias is described in the doc but doesn't work.

GauthierPLM avatar Sep 17 '24 12:09 GauthierPLM

Is it possible to fix it? It will bee pretty easy to rename incoming tls option to lts/*.

zdm avatar Sep 18 '24 09:09 zdm

@HarithaVattikuti Could you, please, make lts works? This is really 5-minutes fix. Just need to translate command line option 'ltstolts/*``. Thank you.

zdm avatar Oct 23 '24 07:10 zdm

I can create PR, this is not a problem, but my experience says, that 99% of PRs from third-party developers are rejected.

zdm avatar Oct 23 '24 07:10 zdm

@zdm if you know where to add - could you please create this PR and link to this issue? Thanks!

ThePlenkov avatar Nov 04 '24 09:11 ThePlenkov

let's merge my PR and forget about this problem, it is already took too long

zdm avatar Nov 05 '24 19:11 zdm

Could somebody process PR please? Or reject it and lets forget about this issue.

zdm avatar Mar 16 '25 11:03 zdm