Add cache-key as output
Description:
Adds cache-key as an output
Related issue:
- https://github.com/actions/setup-node/issues/1129
- https://github.com/actions/setup-node/issues/1181
- https://github.com/actions/setup-node/issues/1152
Check list:
- [ ] Mark if documentation changes are required.
- [X] Mark if tests were added or updated to cover the changes.
Hi @alexdunae, happy to see this PR.
However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.
Hi @alexdunae, happy to see this PR.
However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.
Correct, it was just related but not closing that issue entirely.
I’m happy to add that extra output if it’s of interest?
@ramblingenzyme I've added cache-matched-key as well
@alexdunae only just seeing this now, I hadn't made the distinction between "relates" and "closes off" when I read the PR description originally.
Thanks for adding the second key though, much appreciated. 🙇🏽
@ramblingenzyme no problem. Anything you need to get this merged?
Is it possible to get the second review so this can merge?
Circling back on this @ramblingenzyme is there any way to ping another codeowner to get a second review?
@alexdunae sorry, I'm not actually a codeowner, not sure how to get their attention either. 😢
Hello @alexdunae, Thank you for this Pull request. We will review and get back to you once we have some feedback on this :)
Hello @aparnajyothi-y, is there any update on this PR?