setup-node icon indicating copy to clipboard operation
setup-node copied to clipboard

Add cache-key as output

Open alexdunae opened this issue 1 year ago • 10 comments

Description: Adds cache-key as an output

Related issue:

  • https://github.com/actions/setup-node/issues/1129
  • https://github.com/actions/setup-node/issues/1181
  • https://github.com/actions/setup-node/issues/1152

Check list:

  • [ ] Mark if documentation changes are required.
  • [X] Mark if tests were added or updated to cover the changes.

alexdunae avatar Jan 14 '25 18:01 alexdunae

Hi @alexdunae, happy to see this PR.

However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.

ramblingenzyme avatar Jan 15 '25 00:01 ramblingenzyme

Hi @alexdunae, happy to see this PR.

However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.

Correct, it was just related but not closing that issue entirely.

I’m happy to add that extra output if it’s of interest?

alexdunae avatar Jan 15 '25 00:01 alexdunae

@ramblingenzyme I've added cache-matched-key as well

alexdunae avatar Jan 15 '25 20:01 alexdunae

@alexdunae only just seeing this now, I hadn't made the distinction between "relates" and "closes off" when I read the PR description originally.

Thanks for adding the second key though, much appreciated. 🙇🏽

ramblingenzyme avatar Jan 28 '25 01:01 ramblingenzyme

@ramblingenzyme no problem. Anything you need to get this merged?

alexdunae avatar Jan 31 '25 01:01 alexdunae

Is it possible to get the second review so this can merge?

alexdunae avatar Feb 25 '25 15:02 alexdunae

Circling back on this @ramblingenzyme is there any way to ping another codeowner to get a second review?

alexdunae avatar Mar 14 '25 15:03 alexdunae

@alexdunae sorry, I'm not actually a codeowner, not sure how to get their attention either. 😢

ramblingenzyme avatar May 01 '25 04:05 ramblingenzyme

Hello @alexdunae, Thank you for this Pull request. We will review and get back to you once we have some feedback on this :)

aparnajyothi-y avatar May 02 '25 14:05 aparnajyothi-y

Hello @aparnajyothi-y, is there any update on this PR?

mschfh avatar Oct 30 '25 16:10 mschfh