setup-node icon indicating copy to clipboard operation
setup-node copied to clipboard

need a node installation path option

Open CNOCTAVE opened this issue 1 year ago • 3 comments

Description: In some build tool config, developer need to set node path, as https://github.com/flathub/electron-sample-app/blob/master/flatpak/org.flathub.electron-sample-app.yml , line 17.

Justification: need a node installation path option

Are you willing to submit a PR? OK

CNOCTAVE avatar Nov 14 '24 17:11 CNOCTAVE

Unfortunately, in setup-node current software structure, this feature cannot be added. image

CNOCTAVE avatar Nov 14 '24 17:11 CNOCTAVE

I will submit a PR until setup-node changes software structure.

CNOCTAVE avatar Nov 14 '24 17:11 CNOCTAVE

Hello @CNOCTAVE, Thank you for creating this issue and we will get back to you once we have some feedback on this :)

aparnajyothi-y avatar Nov 18 '24 01:11 aparnajyothi-y

Hello @CNOCTAVE, Thank you for taking the time to submit this feature request and for outlining its rationale. While we recognize the potential benefits of a custom Node.js installation path, implementing it would add complexity around validation, permissions, and security. Given these challenges and the current lack of community traction, we’ve decided not to pursue this feature at this time. We appreciate your feedback and encourage future suggestions. If community interest increases, we’ll be open to revisiting the idea. Thanks again for contributing, and we welcome your feedback for future enhancements.

aparnajyothi-y avatar Jun 18 '25 05:06 aparnajyothi-y

Hello @CNOCTAVE, Please let us know if you have any concerns on the above :)

aparnajyothi-y avatar Jul 02 '25 14:07 aparnajyothi-y

Whatever. I defer Flatpak package packing now.

CNOCTAVE avatar Jul 03 '25 12:07 CNOCTAVE

Hello @CNOCTAVE, Thank you for taking the time to submit this feature request and for outlining its rationale. While we recognize the potential benefits of a custom Node.js installation path, implementing it would add complexity around validation, permissions, and security. Given these challenges and the current lack of community traction, we’ve decided not to pursue this feature at this time. We appreciate your feedback and encourage future suggestions. If community interest increases, we’ll be open to revisiting the idea. Thanks again for contributing, and we welcome your feedback for future enhancements.

aparnajyothi-y avatar Jul 10 '25 16:07 aparnajyothi-y