setup-java icon indicating copy to clipboard operation
setup-java copied to clipboard
verified publisher icon actions

feat: add support for SapMachine JDK/JRE

Open Shegox opened this issue 1 year ago • 10 comments

Description: This PR adds support for setting up the SapMachine JDK/JRE using the setup-java action. The implementation is heavily inspired by the dragonwell implementation. The setup-java supports setting up SapMachine for JRE and JDK for following operating systems/architectures:

  • macos (arm/x86)
  • linux (arm/x86)
  • linux-muse (x86) (for alpine containers)
  • windows (x86)

The releases URL https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json, which is used to determine the download URL, contains the up-to-date full list of all SapMachine JDKs and JREs.

Otherwise this PR adds 21 to the list of major e2e tested versions for all releases, which works for all. If you want I can as well add it to a separate PR.

Related issue: fixes #72 fixes https://github.com/SAP/SapMachine/issues/821

Check list:

  • [x] Mark if documentation changes are required.
  • [x] Mark if tests were added or updated to cover the changes.

Tested additionally via:

  • e2e tests: https://github.com/Shegox/setup-java/actions/runs/8452912940
  • SapMachine specific e2e setup tests: https://github.com/Shegox/setup-sapmachine-test/actions/workflows/matrix.yml

Shegox avatar Mar 27 '24 14:03 Shegox

@aparnajyothi-y can we get a review of this PR please

gdams avatar Apr 10 '24 15:04 gdams

great!

joergmann avatar Apr 16 '24 08:04 joergmann

Great! Go for it! 💚

rjayasinghe avatar Apr 18 '24 06:04 rjayasinghe

@HarithaVattikuti can you take a look?

RealCLanger avatar May 06 '24 14:05 RealCLanger

@priyagupta108 can you take a look?

RealCLanger avatar May 06 '24 14:05 RealCLanger

@mahabaleshwars Could you take a look here or give us some ETA for when this can be merged? We have quite some folks waiting for this... Thanks

RealCLanger avatar May 07 '24 06:05 RealCLanger

@RealCLanger https://github.com/actions/setup-java/pull/501 is stuck in a similar fashion: no response from the maintainers for months. I was told they need their lawyers to review the license of the JDK distro to ensure the distro can be integrated into this action. We went through this with them when adding Oracle JDK (https://github.com/actions/setup-java/pull/401), but somehow it now seems that process is stuck indefinitely.

fniephaus avatar May 07 '24 08:05 fniephaus

@stoe Could you find out something about the progress of this already?

RealCLanger avatar Jul 23 '24 07:07 RealCLanger

Hello Everyone, We have prioritized the feature request to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR. We will update you once we have some feedback.

aparnajyothi-y avatar Jul 23 '24 11:07 aparnajyothi-y

Hello Everyone, We have prioritized the feature request for this Q4 to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR for the feature request. We will update you once we have some feedback.

Thanks for the update. So let's hope this can be integrated by Q4 or even sooner... 😄

RealCLanger avatar Jul 23 '24 13:07 RealCLanger

Hello Everyone, We have prioritized the feature request to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR. We will update you once we have some feedback.

@aparnajyothi-y Hi, can you please give an update how long this will take? Can we help/assist you in any way to get this PR sooner solved? Best Regards Christian

skateball avatar Aug 05 '24 13:08 skateball

Any updates (@aparnajyothi-y) ?

RealCLanger avatar Sep 02 '24 06:09 RealCLanger

Hello Everyone, we are in the process of reviewing this PR. We will update once the review completed.

aparnajyothi-y avatar Sep 02 '24 07:09 aparnajyothi-y