setup-java icon indicating copy to clipboard operation
setup-java copied to clipboard

Add support for Oracle GraalVM JDK

Open fniephaus opened this issue 2 years ago • 10 comments

Description: This PR adds Oracle GraalVM JDK to the list of supported distributions.

Related issue: https://github.com/actions/setup-java/pull/401

Check list:

  • [x] Mark if documentation changes are required.
  • [x] Mark if tests were added or updated to cover the changes.

fniephaus avatar Jun 20 '23 06:06 fniephaus

Any update on this?

fniephaus avatar Sep 20 '23 06:09 fniephaus

@IvanZosimov if you could find time to merge this, it would be really amazing! Thank you for your work.

wetneb avatar Sep 25 '23 18:09 wetneb

Ideally this should support the new release and approach to naming from GraalVM.

Yaytay avatar Oct 06 '23 07:10 Yaytay

@IvanZosimov and @dmitry-shibanov, do you have an update on this? There's now a merge conflict that needs to be resolved but I don't want to do this work if a review and approval still take time.

fniephaus avatar Oct 09 '23 12:10 fniephaus

I'm assuming this is still pending licensing approval, @IvanZosimov? Please let me know if there's anything we can help with.

fniephaus avatar Dec 19 '23 10:12 fniephaus

Maybe @brunoborges could help move this forward?

fniephaus avatar Feb 13 '24 09:02 fniephaus

Is there any update on this? It's been over a year now and it'd be nice if we can move this forward.

fniephaus avatar Jun 21 '24 15:06 fniephaus

@aparnajyothi-y I see that SapMachine support is planned for Q4. Can we please proceed with this and add Oracle GraalVM support, too?

fniephaus avatar Jul 23 '24 11:07 fniephaus

Hello @fniephaus, We are working to prioritize this feature. We will update you once we have some feedback :)

aparnajyothi-y avatar Jul 23 '24 14:07 aparnajyothi-y

Thanks, @aparnajyothi-y. Let me know when this is planned so I can help resolve the merge conflicts. :)

fniephaus avatar Jul 23 '24 16:07 fniephaus

Hi @aparnajyothi-y, any updates here?

SandraAhlgrimm avatar Aug 13 '24 08:08 SandraAhlgrimm

Hello Everyone, we are in the process of reviewing this PR. Feedback will be provided once the review is complete.

HarithaVattikuti avatar Aug 23 '24 21:08 HarithaVattikuti

Feedback will be provided once the review is complete.

Thanks! Let me know and we can work on resolving merge conflicts.

fniephaus avatar Aug 27 '24 15:08 fniephaus

Hi @fniephaus, could you please resolve the conflicts so we can proceed with testing and approving the PR?

mahabaleshwars avatar Sep 05 '24 04:09 mahabaleshwars

Hi @mahabaleshwars, I have resolved the merge conflicts and have added support for GraalVM EA builds. Please test and review the PR and let me know if anything needs changing.

fniephaus avatar Sep 05 '24 08:09 fniephaus

I see there are new merge conflicts. When will this PR be merged? I wouldn't want to keep resolving merge conflicts.

fniephaus avatar Sep 09 '24 15:09 fniephaus

I have resolved the merge conflicts again. It'd be great if this could be merged soon, thanks!

fniephaus avatar Sep 11 '24 06:09 fniephaus

All tests are passing and there are plenty of approvals. When will this be merged? :)

fniephaus avatar Sep 12 '24 06:09 fniephaus