languageservices icon indicating copy to clipboard operation
languageservices copied to clipboard

Skip validation for dynamic environment

Open thezanke opened this issue 9 months ago • 8 comments

fixes: github/vscode-github-actions#222

When the environment of a job is dynamically set the validator is unable to resolve the variables names it has access to; this PR should cause the context provider to skip validation of the variables when this is the case.

This is a an issue that has been around for a while and has been fixed for the "secrets" context provider (see github/vscode-github-actions#41) but was seemingly not addressed for the "variables" context provider. I have duplicated the change to the variables provider.

thezanke avatar May 05 '25 17:05 thezanke

Copilot is a little off... I didn't introduce a new variablesContext, I just moved the instantiation to be up above the block that determines the environment name.

thezanke avatar May 05 '25 17:05 thezanke

Great! This will solve the highest reacted issue in this repo.

Niek avatar May 07 '25 10:05 Niek

Apologies for the copilot spam. I had thought the checks were saying it needed a happy copilot review before sending it to the codeowners, but I realize now I had misinterpreted them.

thezanke avatar May 12 '25 20:05 thezanke

Any updates on this? The issue is still the top issue but nothing seems to be happening?

TheAnarchoX avatar Aug 16 '25 12:08 TheAnarchoX

🙏

giphy

karldanninger avatar Sep 03 '25 18:09 karldanninger

Alt Text

PierreLouisPAUGAM avatar Oct 10 '25 07:10 PierreLouisPAUGAM

...

S2009-dev avatar Oct 27 '25 15:10 S2009-dev

https://github.com/orgs/actions/teams/actions-vscode-reviewers doesn't exist ?!

S2009-dev avatar Oct 27 '25 15:10 S2009-dev