actions
Add string[] option to submodules
Any reason not to move forward with the integration of this PR?
I would really like this feature, since my project has ~20 submodules (some with its own submods), and I only need a hanfdul for my workflow.
Thanks!
@joshmgross @jww3 I picked your names since you are listed as the two major contributors in the last 6 months. Do you know who we should ping to take a look at this? I don't even see checks triggered, which makes me think that the repo protection rules are set so that actions don't start until a review is given.
I don't want to pressure you, since I'm sure you have your fair share of daily work. I just don't know what the process is to get a PR moving. I don't know much (read: anything) about node.js, so I can't tell if this PR is following the CONTRIBUTING.md guidance of keeping PR limited to one logical set of changes or not. Hence, maybe that's why the PR didn't get any attention: because it's not conforming to the standard (understandable)? Or maybe simply repo maintainers don't have the time to keep up with the amount of PRs (also understandable)?
Thanks, and sorry for pulling you in. I just don't know if this PR is dead or just that things move slowly.
👋 Hey @bartgol,
Apologies for the lack of a response here. We aren't currently taking new features for this action.
Feature requests should be done through an issue and we use that to judge interest before deciding to add to this action.
If you're blocked on needing this feature, then I'd recommend forking this action, validating these changes, and using that forked action in your workflow. I realize that's not an ideal situation.
@joshmgross I was not aware of that. I have opened another issue for the request here: #1969 For all others feel free to make the issue heard ;)
Why is this PR being blocked for so long? Seems it needs 3 reviewers to approve, but one of the 3 approvals is somehow disappears...
The last guy is gone?
Only 2 valid approvals now...
@Jihad85-D Would please check this PR?
