actions
Client TLS certificates for AutoscalingRunnerSet
What would you like added?
I'd like to add support for configuring client TLS certificates in AutoscalingRunnerSet
Why is this needed?
In our environment, we use an HTTPS proxy with mTLS for client authentication, e.g.
curl --proxy https://our-proxy --proxy-key $KEY_PATH --proxy-cert $CERT_PATH ...
Currently, only basic HTTP authentication is supported
Additional context
Looking at the code https://github.com/actions/actions-runner-controller/blob/088e2a3a9029f1c85e7bd3d2539f8b8ead5947f9/github/actions/client.go#L222 I think this boils down to threading configuration down to set tls.Config.GetClientCertificate
Thanks for opening this issue! I'm interested in contributing to this. 👋
🤔 Understanding the Requirements
To provide the best solution, I'd like to understand:
Context:
- What's the current behavior?
- What's the expected/desired behavior?
- What's the impact or use case?
Scope:
- Are there any specific requirements or constraints?
- Any preferences for implementation approach?
- Related issues or PRs?
Success Criteria:
- What would "done" look like for this issue?
- Any specific metrics or tests needed?
💪 How I Can Help
I have experience with actions projects and can contribute:
- 🔍 Investigation: Research and propose solutions
- 💻 Implementation: Write clean, tested code
- ✅ Testing: Comprehensive test coverage
- 📚 Documentation: Clear docs and examples
- 👀 Review: Iterate based on feedback
🚀 My Approach
- Understand requirements thoroughly
- Research best practices and similar solutions
- Design before implementing
- Write tests first (TDD)
- Implement incrementally
- Document clearly
- Iterate based on review
Let me know if this is still open and how I can help! I'm excited to contribute. 🎯
My relevant experience:
- Similar projects and features
- Modern development practices
- Open source contribution
- Production system experience
Feel free to assign this to me if you'd like me to work on it! 🙌
