actions-runner-controller icon indicating copy to clipboard operation
actions-runner-controller copied to clipboard

feat(gha-runner-scale-set): ability to set annotations on noPermission service account

Open dotdc opened this issue 1 year ago • 2 comments

Fixes #3678 Fixes #3672

This pull request adds the ability to set custom annotations on the no_permission_serviceaccount for our gha runner scale sets.

This can be needed in some Google Workload Identity setups:

iam.gke.io/gcp-service-account=IAM_SA_NAME@IAM_SA_PROJECT_ID.iam.gserviceaccount.com

Source: https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#kubernetes-sa-to-iam

dotdc avatar Jul 24 '24 07:07 dotdc

can you push this ??? relay needed

noamgreen avatar Jul 26 '24 09:07 noamgreen

Updated PR description, may also fix https://github.com/actions/actions-runner-controller/issues/3672

dotdc avatar Aug 01 '24 05:08 dotdc

Would be nice to have an ability to annotate service account

mishkaexe avatar Dec 10 '24 14:12 mishkaexe

Closing since custom annotations are applied to all resources with this PR

nikola-jokic avatar Mar 10 '25 14:03 nikola-jokic