actions-runner-controller icon indicating copy to clipboard operation
actions-runner-controller copied to clipboard

Support scale subresource to scale Runners with kubectl

Open duhow opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. According to https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#subresources :

Custom resources support /status and /scale subresources. The status and scale subresources can be optionally enabled by defining them in the CustomResourceDefinition.

Describe the solution you'd like Being able to scale RunnerDeployments, RunnerStatefulSets and/or RunnerReplicaSets with kubectl:

kubectl scale rdeploy github-runner --replicas=4

Additional context https://github.com/actions-runner-controller/actions-runner-controller/blob/538e2783d7fde279b84f1ff9351bb1486823660b/charts/actions-runner-controller/crds/actions.summerwind.dev_runnerdeployments.yaml#L5256-L5257

duhow avatar Sep 14 '22 13:09 duhow

Would be realy nice to have it. Keda scaling object can only scale resources implementing /scale subresource.

david-freistrom avatar Aug 18 '23 19:08 david-freistrom

Bit of an old issue, but it would also be good to have this for AutoscalingRunnerSet resources as well

sthomson-wyn avatar Feb 13 '24 14:02 sthomson-wyn

I made a PR for your use case here https://github.com/actions/actions-runner-controller/pull/3291

The AutoscalingRunnerSet use case doesn't make much sense when I think about it. Ultimately I want to set the minReplicas dynamically, so it's slightly different

sthomson-wyn avatar Feb 14 '24 18:02 sthomson-wyn