act-rules.github.io icon indicating copy to clipboard operation
act-rules.github.io copied to clipboard

Create focus-returns-trigger-9au0ou.md

Open HelenBurge opened this issue 2 years ago • 11 comments

First draft of the 2.4.3 focus returns to trigger rule.

Adding a rule for testing the focus returning to the trigger tests.

Closes issue(s):

Need for Call for Review: This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • [ ] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • [ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • [ ] Add yourself (and co-authors) as "Assignees" for PR.
  • [ ] Add label to indicate if it's a Rule, Definition or Chore.
  • [ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • [ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • [ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

HelenBurge avatar Jan 31 '23 11:01 HelenBurge

Okay, I pushed a "Passed Example 1". I'd like to know what you think of it, before I create other examples. The problem is that it will be hard for you to test it. You can't just copy and paste that HTML. I think that your options are:

  1. You can copy the multiple .css and .js files to your local machine and then edit some paths. (If you want to pursue this option, let me know.)
  2. Wait until it's built and released on the ACT rules site (i.e. https://www.w3.org/WAI/standards-guidelines/act/rules/) (this option seems like the worst one to me.)
  3. Discover some other method of viewing the built HTML before it gets published on the ACT rules site. (I don't know if this option exists. Maybe Jean-Yves or Wilco would.)

dan-tripp-siteimprove avatar Feb 17 '23 23:02 dan-tripp-siteimprove

I put "Passed Example 1" on a live test page. What do you think?

dan-tripp-siteimprove avatar Feb 24 '23 23:02 dan-tripp-siteimprove

Love it Dan! Thanks for all of your hard work :)

HelenBurge avatar Mar 02 '23 13:03 HelenBurge

I've been thinking about the examples that use a link (instead of a button) to open the modal. (i.e. passed examples 4, 5 and 6, and failed examples 3 and 4.) Is it best to include these? I gather that using a link in this way is a bad practice - discussed here, for example: https://stackoverflow.com/questions/38594369/is-it-more-accessible-to-use-a-button-or-a-to-open-close-a-modal . Even if people do it, we wouldn't want to encourage it, right?

dan-tripp-siteimprove avatar Mar 08 '23 20:03 dan-tripp-siteimprove

I've been thinking about the examples that use a link (instead of a button) to open the modal. (i.e. passed examples 4, 5 and 6, and failed examples 3 and 4.) Is it best to include these? I gather that using a link in this way is a bad practice - discussed here, for example: https://stackoverflow.com/questions/38594369/is-it-more-accessible-to-use-a-button-or-a-to-open-close-a-modal . Even if people do it, we wouldn't want to encourage it, right?

I agree, but best to allow it as we do not say how to code, but how to test and it is possible to have links that activate modals :(

HelenBurge avatar May 04 '23 11:05 HelenBurge

I've been thinking about the examples that use a link (instead of a button) to open the modal. (i.e. passed examples 4, 5 and 6, and failed examples 3 and 4.) Is it best to include these? I gather that using a link in this way is a bad practice - discussed here, for example: https://stackoverflow.com/questions/38594369/is-it-more-accessible-to-use-a-button-or-a-to-open-close-a-modal . Even if people do it, we wouldn't want to encourage it, right?

I agree, but best to allow it as we do not say how to code, but how to test and it is possible to have links that activate modals :(

Fair. I'll try to do that later in May.

dan-tripp-siteimprove avatar May 05 '23 16:05 dan-tripp-siteimprove