act-rules.github.io
act-rules.github.io copied to clipboard
act-rules
Update autocomplete-valid-value-73f2c2.md
Updates:
- updated fixed values list item in Applicability section adding necessary type values to reflect html specs;
- removed "hidden" type from that list;
- added background note both to better explain fixed values and to clarify autofill anchor mantle for input type hidden.
Closes issue(s):
- closes #1901
Need for Call for Review: This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
- [ ] Make sure you're requesting to pull a branch (right side) to the
developbranch (left side). - [ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description
After creating PR:
- [ ] Add yourself (and co-authors) as "Assignees" for PR.
- [ ] Add label to indicate if it's a
Rule,DefinitionorChore. - [ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
- [ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
When merging a PR:
- [ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.
How to Review And Approve
- Go to the “Files changed” tab
- Here you will have the option to leave comments on different lines.
- Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
- Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
It's probably worth adding some inapplicable examples for this.
Good catch. Added input type submit and hidden examples (trying to explain with an example the idea of the autofill anchor mantle).
