act-rules.github.io icon indicating copy to clipboard operation
act-rules.github.io copied to clipboard

Replacing non-streaming audio with live audio

Open carlosapaduarte opened this issue 4 years ago • 3 comments

Updating 'audio element content has text alternative' (#e7aa44) so that it no longer uses the non-streaming definition which was found to be inaccurate

I'm looking for comments on:

  • The appropriateness of the expectation in the new atomic rule that checks if the audio content is live
  • Suggestions on resources to use for the passed example

After getting this change approved I'll open a new PR changing the other rules that also use the non-streaming definition

Need for Final Call: This will require a 2 weeks Final Call


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

carlosapaduarte avatar Jun 25 '21 16:06 carlosapaduarte

I must've missed that part, what's inaccurate with "non-streaming"?

ajanec01 avatar Jun 29 '21 08:06 ajanec01

This: https://github.com/act-rules/act-rules.github.io/issues/1446#issue-701040347

carlosapaduarte avatar Jun 29 '21 08:06 carlosapaduarte

Updated rule, now with a working example.

carlosapaduarte avatar Sep 06 '21 18:09 carlosapaduarte