act-rules.github.io icon indicating copy to clipboard operation
act-rules.github.io copied to clipboard

Update 3 example descriptions to newer format

Open EmmaJP opened this issue 4 years ago • 1 comments

Minor updates to 3 of the example descriptions to the newer format requirements, in https://act-rules.github.io/rules/6a7281 - ARIA state or property has valid value.

Need for Final Call:

  • no need for final call.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

EmmaJP avatar Mar 19 '21 16:03 EmmaJP

@WilcoFiers Mira and I didn't go further because I didn't know if Passed Example 4 needed an element with the referenced id in the associated code snippet. Potentially a change that might need a final call, so not sure how you want to proceed.

Also, I don't know Mira's github id to assign the PR to her.

EmmaJP avatar Mar 19 '21 16:03 EmmaJP

This PR is completely out of date. All tests have since been rewritten.

WilcoFiers avatar Aug 31 '23 14:08 WilcoFiers