lightning icon indicating copy to clipboard operation
lightning copied to clipboard

Remove hook_install() from generated subprofiles

Open danepowell opened this issue 7 years ago • 3 comments

Lightning doesn't have a hook_install() implementation in the base profile, I think specifically so that it will be compatible with the new D8.6 feature of installing site from existing config.

However, the subprofile template still creates a hook_install() implementation, which breaks the ability to install sites from existing config.

An example of this breaking things: https://github.com/acquia/blt/pull/3241#issuecomment-439105307

danepowell avatar Nov 15 '18 17:11 danepowell

+1 for removing the function, but to compensate for that, let's keep the comment explaining that hook_install() should be implemented in order to do various tasks. But let's also mention that it will render the profile incompatible with config installs, and cite a change record to back that up.

phenaproxima avatar Nov 15 '18 17:11 phenaproxima

I added the requested comments. I don't think the test failures are specific to this PR.

danepowell avatar Nov 16 '18 21:11 danepowell

Rerunning tests. RTBC from me if they pass - which they should.

balsama avatar Dec 18 '18 18:12 balsama