acmel
cmake: Use GNUInstallDirs to install data directories
Solves issues with cross environments where prefix is set to e.g. -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and the arch independent files would end up under the prefix as well instead of /usr/share.
Note: variables offered by CMake GNUInstallDirs could probably be used for the various other stuff as well like for getting rid of the __lib hack by using CMAKE_INSTALL_LIBDIR but I just wanted to solve an actual issue I ran across with this PR.
Can I add a
Signed-off-by: you
Tothe patch?
On Wed, Apr 12, 2023 at 4:15 PM Timo Gurr @.***> wrote:
Solves issues with cross environments where prefix is set to e.g. -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and the arch independent files would end of under the prefix as well instead of /usr/share.
Note: variables offered by CMake GNUInstallDirs could probably used for the various other stuff as well like for getting rid of the __lib hack by using CMAKE_INSTALL_LIBDIR but I just wanted to solve an actual issue I ran across with this PR.
You can view, comment on, or merge this pull request online at:
https://github.com/acmel/dwarves/pull/41 Commit Summary
- 01213b6 https://github.com/acmel/dwarves/pull/41/commits/01213b644853cffa0af4f38e31f2442d4c5bce17 cmake: Use GNUInstallDirs to install data directories
File Changes
(1 file https://github.com/acmel/dwarves/pull/41/files)
- M CMakeLists.txt https://github.com/acmel/dwarves/pull/41/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a (8)
Patch Links:
- https://github.com/acmel/dwarves/pull/41.patch
- https://github.com/acmel/dwarves/pull/41.diff
— Reply to this email directly, view it on GitHub https://github.com/acmel/dwarves/pull/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIAU5X5HXIFTBQMFHK5NR3XA35MFANCNFSM6AAAAAAW4DADKY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Can I add a Signed-off-by: you Tothe patch?
@acmel Sure yes, whatever you want. Also please tell if I should rather do it myself if that's easier for you.
Em Wed, Apr 12, 2023 at 01:06:27PM -0700, Timo Gurr escreveu:
Can I add a Signed-off-by: you Tothe patch?
@acmel Sure yes, whatever you want. Also please tell if I should rather do it myself if that's easier for you.
I can do it, thanks!
- Arnaldo
-- Reply to this email directly or view it on GitHub: https://github.com/acmel/dwarves/pull/41#issuecomment-1505854229 You are receiving this because you were mentioned.
Message ID: @.***>
Can I add a Signed-off-by: you To the patch?
@acmel I've updated the PR to add the requested Signed-off-by.