Austin Clements
Austin Clements
I've just filed #61515, which I consider closely related to and complementary to this proposal and the `Iterate` proposal. I suggest we keep discussions of trade-offs between `Iterate`, `Keep`, and...
> So, if we wanted to benchmark inlining of unicode.IsSpace with the constant argument 'x', I guess that would be written as: I believe your example is right. It's awkward,...
The current proposal is to add the following field to [acme.Challenge](https://pkg.go.dev/golang.org/x/crypto/acme#Challenge): ``` // Payload is the JSON-formatted payload that the client sends // to the server to indicate it is...
I would like for the doc comment to be a little more prescriptive. Perhaps point at the extension spec and/or suggest *why* one would want to set this field. Could...
Have all remaining concerns about this proposal been addressed? Add the following field to [acme.Challenge](https://pkg.go.dev/golang.org/x/crypto/acme#Challenge): ``` // Payload is the JSON-formatted payload that the client sends // to the server...
Based on the discussion above, this proposal seems like a **[likely accept](https://go.dev/s/proposal-status#likely-accept)**. Add the following field to [acme.Challenge](https://pkg.go.dev/golang.org/x/crypto/acme#Challenge): ``` // Payload is the JSON-formatted payload that the client sends //...
No change in consensus, so **[accepted](https://go.dev/s/proposal-status#accepted)**. 🎉 This issue now tracks the work of implementing the proposal. Add the following field to [acme.Challenge](https://pkg.go.dev/golang.org/x/crypto/acme#Challenge): ``` // Payload is the JSON-formatted payload...
Since this is so closely related to testing.Keep and testing.B.Iterate, which are both being discussed on #61179, let's keep discussions of trade-offs over on #61179. (It's probably fine to discuss...
> It's not clear to me which optimizations those would be. Certainly an unused return value should not be eliminated, but should function arguments be inlined? I think we would...
I mentioned in the original post that `testing.B.Loop` helps with issues around time spent doing benchmark setup, since it can easily ignore that time. Another aspect of this that just...