diffusion_models icon indicating copy to clipboard operation
diffusion_models copied to clipboard

fix the minus sign in diffsuion 01

Open George-Jiao opened this issue 3 years ago • 1 comments

File: diffusion_01_score.ipynb. In the section 'Denoising score matching', the $\nabla_{\tilde{\mathbf{x}}} \log q_{\sigma}(\tilde{\mathbf{x}}\mid\mathbf{x})$ should be $= -\frac{\tilde{\mathbf{x}} - \mathbf{x}}{\sigma^{2}}$ instead of $= \frac{\tilde{\mathbf{x}} - \mathbf{x}}{\sigma^{2}}$. Again, thanks for your repository, it is an awesome tutorial about score matching and diffusion model.

George-Jiao avatar Nov 12 '22 03:11 George-Jiao

I believe this is true as can be seen in the code cell below that equation (-1/sigma**2*(perturbed_samples-samples). Maybe @esling can review and merge the PR?

pieris98 avatar Nov 09 '23 22:11 pieris98