Loris icon indicating copy to clipboard operation
Loris copied to clipboard

Dicom archive 'Download as CSV' button now works properly

Open nicolasbrossard opened this issue 11 months ago • 4 comments

When accessing the dicom archive module and clicking on the 'Download as CSV' button, the downloaded file would be missing column 'Center ID'. This PR fixes the behaviour of the download button so that all columns appear in the result set.

Fixes #9663

nicolasbrossard avatar Mar 07 '25 19:03 nicolasbrossard

Hi @nicolasbrossard,

I looked the file. The CenterID column now appears in the CSV, but the data it contains does not make sense. It reports Y or N rather than a number. data-2025-03-14T14_34_40.256Z.csv

charliehenrib avatar Mar 14 '25 14:03 charliehenrib

@nicolasbrossard See Charlie's comment to be fixed & then re-reviewed

CamilleBeau avatar Mar 31 '25 19:03 CamilleBeau

@charliehenrib @CamilleBeau This PR was not merged so the bug is most likely still there on the test VM. If you checked out my branch on your VM and then tested, then my fix does not work. Can you plz tell me which scenario corresponds to what you did?

nicolasbrossard avatar Apr 01 '25 19:04 nicolasbrossard

@charliehenrib @CamilleBeau This PR was not merged so the bug is most likely still there on the test VM. If you checked out my branch on your VM and then tested, then my fix does not work. Can you plz tell me which scenario corresponds to what you did?

I tested it on the test VM which is probably why the issue was still present.

charliehenrib avatar Apr 02 '25 00:04 charliehenrib