Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[Login] Add login suggestion and redirection for error 403

Open maximemulder opened this issue 2 years ago • 2 comments

Brief summary of changes

Whenever an unauthenticated gets a 403 error, they can try logging in and be redirected to the page they got the 403 on.

  • [ ] Have you updated related documentation?

Testing instructions (if applicable)

  1. Go to a page that exists and require authentication while not being authenticated.
  2. Click "Try logging in"
  3. Log in (after one or several tries)
  4. You are redirected to the previous page

I implemented this using an URL query parameter, but I guess using window.history could also have worked. If anyone has an opinion on this please tell me.

maximemulder avatar Feb 02 '24 16:02 maximemulder

@ridz1208 can you review?

driusan avatar Feb 27 '24 19:02 driusan

I just noticed that I did this PR quite some time ago and wasn't aware of the testing plan at the time, gonna add it before merging.

maximemulder avatar Mar 14 '24 14:03 maximemulder