Loris icon indicating copy to clipboard operation
Loris copied to clipboard

Add range capabilities to the filters

Open ridz1208 opened this issue 2 years ago • 6 comments

Is your feature request related to an existing module? Applies to all filters in all modules

Describe the solution you'd like We need the possibility of searching for ranges whether its for dates of numbers it would be nice to be able to filter for >= or <=

ridz1208 avatar Nov 08 '23 17:11 ridz1208

required by

  • CBIG
  • COPN
  • EEG Net

ridz1208 avatar Nov 08 '23 18:11 ridz1208

Make sure you code the web form with a non-literal comparison operator in it.

The first time we implemented < and => etc comparisons in CBRAIN, the developer encoded the operators directly in the form, and so it immediately became a source of SQL injection (a bad user could just edit the form and change the '>' for things like ; drop table users -- )

prioux avatar Nov 08 '23 18:11 prioux

I told the developer to assign a numerical code to the comparison. e.g. 1 for >, 2 for <, 3 for != etc etc

prioux avatar Nov 08 '23 18:11 prioux

I think on LORIS all filtering is being done directly front end so no risk of that but thanks for the heads up.

ridz1208 avatar Nov 08 '23 18:11 ridz1208

Ah, sure. Yes, I was of course talking about code ending up on the backend. Front end, no problem, of course.

prioux avatar Nov 08 '23 18:11 prioux

@jeffersoncasimir is this something that could be added from eegnet's sliders?

@racostas could this be a good first task for Ayush? gsoc

@ridz1208 @driusan is there anyone else who should tackle this instead?

The CAP project implemented range selection as a slider for filtering candidate age

christinerogers avatar May 07 '24 15:05 christinerogers

@driusan I'd like that on the roadmap, unless there are plans on using the DQAPI to replace it

ridz1208 avatar Sep 18 '24 16:09 ridz1208