Loris icon indicating copy to clipboard operation
Loris copied to clipboard
verified publisher icon aces

[tools] Implement LorisInstance in tools directory

Open CamilleBeau opened this issue 3 years ago • 5 comments

Describe the bug Plenty of tools were failing because they had not been updated to pass a LorisInstance as an argument to various functions.

The following tools were failing: delete_ignored_conflicts.php detect_conflicts.php lorisform_parser.php lorisform_parser.php score_instrument.php

To Reproduce Steps to reproduce the behavior (attach screenshots if applicable):

  1. Run the above tools as intended
  2. See error

CamilleBeau avatar Mar 18 '22 00:03 CamilleBeau

For some reason i'm not able to edit the description properly, but fix_candidate_age.php should also be on this list instead of lorisform_parser.php twice.

CamilleBeau avatar Mar 22 '22 15:03 CamilleBeau

the critical ones were fixed, but there's still some other ones that need to be fixed according to @CamilleBeau.. @CamilleBeau can you give a list of which are outstanding?

driusan avatar Mar 23 '22 15:03 driusan

the critical ones were fixed, but there's still some other ones that need to be fixed according to @CamilleBeau.. @CamilleBeau can you give a list of which are outstanding?

delete_ignored_conflicts.php detect_conflicts.php

CamilleBeau avatar Mar 23 '22 15:03 CamilleBeau