Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[DQT] Define field tab - cannot select a Visit in Visits filter

Open laemtl opened this issue 5 years ago • 3 comments

In DQT > Define field tab, the checkboxes in the Visits menu dropdown are not selectable when no fields are selected.

If this is the intended behavior, I suggest adding a visual indication that those checkboxes are disabled.

With some console debugging, I noticed the click event is fired twice.
Observed in Chrome 75.0.3770.80 and Firefox 76.0.1.

To reproduce

  • Go to Reports > Data Query Tool
  • Select the Define field tab
  • Select an instrument
  • Interact with the Visits filter on the right

laemtl avatar May 22 '20 14:05 laemtl

@laemtl I observed the same issue when testing today. I think that this behavior makes sense and is therefore intended. But I agree with you that there should be a visual indication that the Visit checkbox is disabled until you select a field.

AlexandraLivadas avatar Jun 08 '20 20:06 AlexandraLivadas

let's file this under Improvements/Cleanup -- cc @maltheism can this nicety be added to the DQT renovation roadmap?

christinerogers avatar Jun 08 '20 21:06 christinerogers

@maltheism I don't believe this was part of the redesign was it ? if so please close the issue

ridz1208 avatar Jul 08 '21 17:07 ridz1208