Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[API] Adding dicom upload

Open xlecours opened this issue 5 years ago • 10 comments

Copy of https://github.com/aces/Loris/pull/5016

This adds POST /candidates/<candid>/<visit>/dicoms to upload a dicom. GET /candidates/<candid>/<visit>/dicoms/<filename>/processes to get the server processes related to that dicom upload (mri_upload) POST /candidates/<candid>/<visit>/dicoms/<filename>/processes to start a mri_upload server process on that dicom. GET /candidates/<candid>/<visit>/dicoms/<filename>/processes/<processid> to get the state of a process

This work is based on https://github.com/aces/Loris/pull/4244 To see this PR changes go to https://github.com/xlecours/Loris/compare/api-module-candidates-and-subs...xlecours:adding_dicom_upload

TODO:

  • [ ] Add documentation for the new endpoints.
  • [ ] Make the imaging_uploader use it.
  • [x] Sync FilesUploadHandler.class.inc, UploadException.class.inc with John's PR https://github.com/aces/Loris/pull/4181

xlecours avatar Mar 16 '20 18:03 xlecours

I am waiting for https://github.com/aces/Loris/pull/6671 to get merged so I can add tests

xlecours avatar Aug 10 '20 15:08 xlecours

This needs to go in a 0.0.4-dev, not 0.0.3

driusan avatar Sep 01 '20 13:09 driusan

@xlecours could you rebase your branch?

cmadjar avatar Jun 08 '21 13:06 cmadjar

@xlecours I rebased this for you here https://github.com/ridz1208/Loris/tree/adding_dicom_upload

if you want I can force push to your branch or you can simply pull it and force push it yourself.

ridz1208 avatar Jun 23 '21 18:06 ridz1208

@cmadjar @driusan this one is now rebased and seems to be passing tests

ridz1208 avatar Jun 28 '21 19:06 ridz1208

This is missing integration tests. @xlecours

xlecours avatar Jul 13 '21 13:07 xlecours

@cmadjar can you review?

driusan avatar Aug 10 '21 13:08 driusan

@xlecours If you do the rebase, @cmadjar agreed to review it again. Also, now that we have a testsuite for the api module, you should add some tests.

xlecours avatar Nov 29 '22 21:11 xlecours

@xlecours are you referring to yourself in the third person? Who's supposed to be writing tests?

driusan avatar Nov 30 '22 19:11 driusan

@xlecours are you referring to yourself in the third person? Who's supposed to be writing tests?

Yes, I am.

xlecours avatar Nov 30 '22 20:11 xlecours

Replaced by #9154

driusan avatar Nov 07 '24 15:11 driusan