[API] Adding dicom upload
Copy of https://github.com/aces/Loris/pull/5016
This adds
POST /candidates/<candid>/<visit>/dicoms to upload a dicom.
GET /candidates/<candid>/<visit>/dicoms/<filename>/processes to get the server processes related to that dicom upload (mri_upload)
POST /candidates/<candid>/<visit>/dicoms/<filename>/processes to start a mri_upload server process on that dicom.
GET /candidates/<candid>/<visit>/dicoms/<filename>/processes/<processid> to get the state of a process
This work is based on https://github.com/aces/Loris/pull/4244 To see this PR changes go to https://github.com/xlecours/Loris/compare/api-module-candidates-and-subs...xlecours:adding_dicom_upload
TODO:
- [ ] Add documentation for the new endpoints.
- [ ] Make the imaging_uploader use it.
- [x] Sync FilesUploadHandler.class.inc, UploadException.class.inc with John's PR https://github.com/aces/Loris/pull/4181
I am waiting for https://github.com/aces/Loris/pull/6671 to get merged so I can add tests
This needs to go in a 0.0.4-dev, not 0.0.3
@xlecours could you rebase your branch?
@xlecours I rebased this for you here https://github.com/ridz1208/Loris/tree/adding_dicom_upload
if you want I can force push to your branch or you can simply pull it and force push it yourself.
@cmadjar @driusan this one is now rebased and seems to be passing tests
This is missing integration tests. @xlecours
@cmadjar can you review?
@xlecours If you do the rebase, @cmadjar agreed to review it again. Also, now that we have a testsuite for the api module, you should add some tests.
@xlecours are you referring to yourself in the third person? Who's supposed to be writing tests?
@xlecours are you referring to yourself in the third person? Who's supposed to be writing tests?
Yes, I am.
Replaced by #9154