ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Add CUP Weapons Compatibility

Open Mike-MF opened this issue 2 years ago • 7 comments

When merged this pull request will:

  • Merges CUP Weapons Compat from CUP to ACE.

ToDo:

  • [ ] Test all of it
  • [x] Figure out what to do with the Laserpointer stuff in original compat
  • [x] Figure out what to do with the displayName in CSW subconfig/magazines/L38 & L49
  • [x] Remove Tabs

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Mike-MF avatar Oct 28 '23 01:10 Mike-MF

laserpointer

Nuke it and convert to engine method like ACE difld

LinkIsGrim avatar Oct 28 '23 01:10 LinkIsGrim

Figure out what to do with the Laserpointer stuff in original compat

Do what you did on CUP. I don't know if we want to remove it from CUP or just modify here though.

jonpas avatar Oct 28 '23 05:10 jonpas

Ah, it's a clone of what's done in base CUP already. Mostly just setting the extra modes to scope = 1

Mike-MF avatar Oct 28 '23 13:10 Mike-MF

will only pass CI on merge (due to changes to workflow)

PabstMirror avatar Oct 31 '23 17:10 PabstMirror

Hi, I found something in the old CUP weapons ace compat. In the PVS7 part, some descriptions list below: // Should have eye cups, but current ACE3 NVG implementation has UI behind // NVG overlay making it completely hidden if eye cups are enabled But #9614 has been merged, so will it be OK to set ace_nightvision_eyeCups = 1 for PVS7 now?

acknowledge14 avatar Nov 09 '23 07:11 acknowledge14

Thoughts on adding a big pop-up warning for duplicate compats?

20240122172101_1

PabstMirror avatar Jan 22 '24 23:01 PabstMirror

Approved by CUP Team. Their compats will be removed from Workshop on release.

jonpas avatar Jan 26 '24 12:01 jonpas