acemod
Cargo - Add Cargo UI to the Inventory UI
When merged this pull request will:
- Replaces the Cargo UI for Vehicles and Objects that is included in the Normal Vanilla Inventory
- Adds a Dirty Workaround for all Objects to have a "Inventory" Action
TODO
- [x] Reopen the Correct UI depending on what was used for Unloading/Paradrop if ReopenOnX is used
- [x] Fully Replace ~~the other UI Element else add a Setting to toggle between or have both?~~
- [x] Test with Different Aspect Ratios
Discussion Points
Should this be a replacement or an alternative maybe with an extra Setting? If we go for a full replacement of the current UI we need to be clear that
IMPORTANT
- [ ] If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- [x] Development Guidelines are read, understood and applied.
- [x] Title of this PR uses our standard template
Component - Add|Fix|Improve|Change|Make|Remove {changes}.
I think a replacer is fine if this matches the inventory UI design (pictures and thicker line, no need for quantity).
Need to make sure it works the same though (like passengers in aircraft not being able to unload cargo, although, I've seen requests for that).
I think a replacer is fine if this matches the inventory UI design (pictures and thicker line, no need for quantity).
well, it matches as far as we can match. we don't have/can't produce all the images we would need for the inventory items for those I think, so it is currently just a list similar to the current cargo UI just directly integrated in the Inventory UI
Need to make sure it works the same though (like passengers in aircraft not being able to unload cargo, although, I've seen requests for that).
That should already be handled by those lines https://github.com/acemod/ACE3/pull/9502/files#diff-079026a24a4965fcf78d16170da41a373fa8639fc8fb424d745abb63e56ebd53R35-R40
From my testing, having the UI Reopen automatically when the player has Carray After Unload enabled does not make sense because Reopening the Inventory forces a player Animation to happen and resets the carry animation.
One more question is if we want to re-add a "text" form of the filling of the Vehicle as currently it is handled via the bar at the bottom
I don't think we need to match Inventory UI exactly, as it is a different purpose.
One more question is if we want to re-add a "text" form of the filling of the Vehicle as currently it is handled via the bar at the bottom
Only text, it makes more sense when the entire system is designed around discrete values.
I assume the loaded cargo item text is the same (including name etc.) as on the old cargo menu?
