ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Extensions - Rust

Open BrettMayson opened this issue 3 years ago • 8 comments

When merged this pull request will:

  • Merge all extensions into one
  • It's now in Rust though
  • Use fancy callExtension features instead of : deliminated strings

TODO:

  • [x] advanced_ballistics
  • [x] artillerytables
  • [x] break_line
  • [x] clipboard
  • [x] fcs

Medical and dynload are no longer needed

BrettMayson avatar Aug 27 '22 00:08 BrettMayson

take a look at number formatting

Rust

20220830193305_1

Old

20220830193501_1

PabstMirror avatar Aug 31 '22 00:08 PabstMirror

take a look at number formatting

fixed, 3rd column still has a decimal but it fits, should it be set back to whole values?

Fixed

image

BrettMayson avatar Aug 31 '22 00:08 BrettMayson

Found an issue with ballistic simulation, not ready for merge

BrettMayson avatar Dec 11 '22 18:12 BrettMayson

Will need to update with #9298 when merged. I'd like to get this merged after v3.16.0 release.

jonpas avatar Sep 26 '23 22:09 jonpas

trying to convert xm157 - https://github.com/acemod/ACE3/commit/8b73cebd48450ec9d6483baca1d6b5aeed390158

old:
"ace_advanced_ballistics" callExtension "atmosphericCorrection:0.263:25.3642:1009.61:0.603173:ICAO"
"0.275444"

new:
"ace" callExtension ["ballistics:atmospheric_correction",[0.263,25.3642,1009.61,0.603173,"ICAO"]]
["",34,0]

not sure why I'm not getting a return?

PabstMirror avatar Jan 19 '24 02:01 PabstMirror

Do we want to keep references to the medical extension or can I make a PR removing said references?

johnb432 avatar Jun 22 '24 18:06 johnb432

I think we should setup some ingame unit tests for extensions where possible before going through with this, for sanity's sake.

LinkIsGrim avatar Jun 22 '24 18:06 LinkIsGrim

AB LGTM

LinkIsGrim avatar Jun 24 '24 10:06 LinkIsGrim