ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

UI - Add HUD Framework

Open LinkIsGrim opened this issue 4 years ago • 5 comments

When merged this pull request will:

  • Add public API for drawing HUD Elements via cutRsc on postInit alongside ACE HUD Elements.
  • Port Advanced Fatigue Stamina Bar, Medical Feedback Indicators & UI Speed Indicator to HUD Framework.
  • Cleanup some Advanced Fatigue code.

UI elements are drawn in postInit and have their conditions checked on ace_infoDisplayChanged event. They are hidden on featureCamera player event as well as when opening map, pause menu, group (Team Switch) menu, and debriefing screen in multiplayer.

Still very WIP. Posting to see community reaction & feedback. Ideally this should be able to handle most of the project's UI elements.

IMPORTANT

  • [x] If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • [x] Development Guidelines are read, understood and applied.
  • [x] Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

LinkIsGrim avatar Dec 26 '21 17:12 LinkIsGrim

Framework seems way more fitting to live in a ui component.

jonpas avatar Dec 26 '21 18:12 jonpas

Kept in common so as not to change dependencies for other components, though I do agree.

LinkIsGrim avatar Dec 26 '21 19:12 LinkIsGrim

Is dependency a problem?

jonpas avatar Dec 26 '21 19:12 jonpas

Internally, probably not. But it would hurt modularity if every component adding UI required ui. I don't personally know of any third-party builds that omit it, but they might exist.

LinkIsGrim avatar Dec 26 '21 19:12 LinkIsGrim

If UI only provides framework and settings, there is zero problems with that. Custom packs are the responsibility of the packer, we have solid documentation on requirements.

jonpas avatar Dec 26 '21 19:12 jonpas