Update rxjsObservableConfig for rxjs 6
Need some discussion before merging:
-
There were
rxjs4ObservableConfig.jsandrxjsObservableConfig.js(for rxjs 5) before. This PR upgraderxjsObservableConfig.jsdirectly to adopt rxjs 6, but it's a breaking change. We might want to create separate files for both rxjs 5 and rxjs 6. -
Rxjs used to polyfill
Symbol.observable, but it has been removed since https://github.com/ReactiveX/rxjs/pull/3387. We might need to add a notice about polyfillSymbol.observableto the doc.
What are u think to split library on 2, ie recompose and recompose-rx(-observable, -blabla) and move all the streaming parts out of the recompose library.
Also I think we can move on https://github.com/facebook/react/tree/master/packages/create-subscription to support async in the future
It would be a good idea to separate them. But I'm thinking about keeping the es-observable parts remain in Recompose and move only those 3rd-party-config files into other libraries. The reason for me to separate them is to have better version controlling.
And yes, I think we need to introduce create-subscription to handle streaming events.
RxJS 6 has been out for awhile now. Is this PR good to merge? Re. the suggestion of moving 3rd-party-config files into other libraries, perhaps keep that idea to a separate PR, so we can unblock this one?
For those people waiting for this PR, there is a simple configuration possible to get recompose working with RxJS@^6.0.0:
import { from } from 'rxjs';
setObservableConfig({
fromESObservable: from,
});