Gource icon indicating copy to clipboard operation
Gource copied to clipboard

Added lines count display option

Open mcallegari opened this issue 8 years ago • 5 comments

At the moment works only with GIT Enabled with --lines

mcallegari avatar Dec 06 '17 11:12 mcallegari

@acaudwell any particular reason for not merging this yet ?

mcallegari avatar Dec 17 '17 14:12 mcallegari

I haven't had a good look at it yet.

acaudwell avatar Dec 21 '17 19:12 acaudwell

It's nice, I've tried it out. Good work!

Damov avatar Dec 27 '17 11:12 Damov

The "obviously wrong delta lines calculation" may not the correct solution either. Git counts added lines and removed lines in an odd way. Any change/edit to an existing line counts as 1 add and 1 remove. If you subtract you get 0. This is why most git based line-counts report adds and removes separately. If you just want to count changed lines its just "added" total. The removed - added may reflect actual removed code but I have found git is not always accurate with determining replace vs add so I prefer to just count "added" and not worry about "removed". I actually find the entire idea of line-counts useless and prefer commit counts ;)

ghost avatar Jan 29 '18 22:01 ghost

Hi, Is it still possible to implement this feature? Or the limit described in https://github.com/acaudwell/Gource/pull/136#issuecomment-361406551 is still an issue?

sinux-l5d avatar May 14 '21 16:05 sinux-l5d