abseil
Expand ABSL_INTERNAL_DLL_TARGETS to avoid static libs on windows when BUILD_SHARED_LIBS=ON
Fixes #1114
More details in second commit message; first one has no changes other than alphabetizing the list for better legibility.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
For more information, open the CLA check for this pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @derekmauro
I'm very sorry this fell by the wayside so long. Would this PR still be useful / acceptable if it excluded all the flag targets?
@derekmauro: Can you remove the flags related targets?
@h-vetinari: Would this PR still be useful / acceptable if it excluded all the flag targets?
I've done this now.
With https://github.com/abseil/abseil-cpp/commit/6d806da76f9dff9c21729f850c6b0e5e727a4281 having landed, this PR is now much shorter. :)
PTAL @derekmauro
Sorry for the delay on this one. There are some things I need to take a look at before I can merge this one. Please be patient.
No worries, it also got stuck on my end for a while. Just wanted to let you know on the occasion of rebasing out the largest part of the PR.
Sorry for the delay on this one. There are some things I need to take a look at before I can merge this one. Please be patient.
Gentle ping @derekmauro; I also rebased the branch to current master.
@derekmauro @mkruskal-google I rebased this for the new LTS now; it's still necessary for us in conda-forge, would be nice if we could get this merged.
The one thing I wanted to check is the status of absl_log_flags: further up, @derekmauro said that all the absl_flags* libs are not supported for shared builds, but it's unclear to me (just from the name) if that applies to absl_log_flags as well. For the moments I've included it in ABSL_INTERNAL_DLL_TARGETS along with all the other absl_log* targets.
Rebased this PR. It's been shipping in conda-forge for quite a while now, and is also compatible with the test target installation. It's also not adding any more flag-related libraries.
PTAL @derekmauro