abp icon indicating copy to clipboard operation
abp copied to clipboard

Bundle command should work with different versions

Open yekalkan opened this issue 1 year ago • 10 comments

We will separate framework and cli versions soon. So, version matching in bundle command will be a problem.

@maliming You can ask me and @enisn for more information.

yekalkan avatar Apr 22 '24 12:04 yekalkan

Here is the case:

ABP CLI version is 8.1.1 and when you try to run abp bundle for project with ABP version 8.0.2 it fails to load DLLs since because it tries to load all project assemblies into CLI's own process at runtime,

enisn avatar Apr 22 '24 12:04 enisn

It works for me.

image

maliming avatar Apr 23 '24 02:04 maliming

This is a wider problem, maybe we can install local tool in the directory with the same version with project instead using global in project folders

enisn avatar May 13 '24 06:05 enisn

it fails to load DLLs

How can I reproduce this?

maliming avatar May 13 '24 06:05 maliming

It works now with 8.3/8.2 CLI on 8.0 projects. But When you try to bundle project 7.4 or version with breaking-changes it'll fail.

How about placing dotnet-tools.json in projects with the same version of project and execute always same CLI version with project?

image

enisn avatar May 13 '24 06:05 enisn

Each project can use their own version CLI different than global cli version

enisn avatar May 13 '24 06:05 enisn

Developers should use the same CLI version as the project package version, at least the same NET platform version. (net 7, net 8)


Of course, they can install CLI at the folder level.

https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install#description

maliming avatar May 13 '24 07:05 maliming

Developers should use the same CLI version as the project package version, at least the same NET platform version. (net 7, net 8)

Of course, they can install CLI at the folder level.

https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install#description

Should we include dotnet-tools.json file in the templates?

enisn avatar May 14 '24 05:05 enisn

We can output a warning message for the abp bundle command and add a document to explain this.

Include dotnet-tools.json still requires the developer to do extra work, so I think we can tell the developer to install the CLI herself/himself.

maliming avatar May 14 '24 06:05 maliming

Yes,dotnet tool restore must be executed manually, so it needs extra work. You're right, we can explain with warning message when version mismatch with project

enisn avatar May 14 '24 06:05 enisn