WebSocket code has same incorrect server certificate verification logic as em-http-request

Open lawrence-forooghian opened this issue 1 year ago • 2 comments

The issue described in #396 also exists in our WebSocket code (although it's not currently causing a test failure since we don’t use Let’s Encrypt on our WebSocket endpoint). Fix it.

┆Issue is synchronized with this Jira Task by Unito

Apr 25 '24 18:04 lawrence-forooghian

Seems similar issue was patched as a part of https://github.com/ably/ably-ruby/pull/234

Jun 05 '24 11:06 sacOO7

I might be missing something but I think that #234 just pulls in the verification logic from em-http-request, i.e. the incorrect logic described in #396?

Jun 05 '24 11:06 lawrence-forooghian