ably-ruby icon indicating copy to clipboard operation
ably-ruby copied to clipboard

Consider removing Faraday

Open mattheworiordan opened this issue 7 years ago • 2 comments

Removing Faraday will reduce the dependencies, but should also allow us to take a little more control over the underlying library.

See https://github.com/excon/excon/issues/682 for example, something we should be able to resolve easily by changing settings, but this is not possible because of https://github.com/lostisland/faraday/blob/master/lib/faraday/adapter/excon.rb#L22-L24.

┆Issue is synchronized with this Jira Task by Unito

mattheworiordan avatar Aug 12 '18 17:08 mattheworiordan

➤ Matthew O'Riordan commented:

This may no longer apply given https://github.com/ably/ably-ruby/pull/197 ( https://github.com/ably/ably-ruby/pull/197|smart-link )

ably-sync-bot avatar Feb 05 '21 23:02 ably-sync-bot

@mattheworiordan Do you think we should still remove Faraday? What benefit will this bring to the codebase?

deanna-lad avatar Jul 04 '22 16:07 deanna-lad