ably-java icon indicating copy to clipboard operation
ably-java copied to clipboard

Code cleanup and warning checkup

Open qsdigor opened this issue 3 years ago • 2 comments

While working on implementation/version-2 I noticed many deprecated methods, lousy formatting, and other warnings.

Running lint revealed 133 errors, 2.297 warnings, 56 week-warnings, and 1.393 typos. While a lot of them are not valid warnings a lot of them are and should be addressed.

We should run code formatting and optimize imports so everything is tidy.

┆Issue is synchronized with this Jira Task by Unito

qsdigor avatar Oct 24 '22 13:10 qsdigor

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2866

sync-by-unito[bot] avatar Oct 24 '22 13:10 sync-by-unito[bot]

Work on this issue will need to include adding these lint checks to CI in our check workflow. I understand from @qsdigor that the command he's using locally (which we don't currently run in CI) is ./gradlew lint or in IntelliJ "toolbar -> code -> inspect code -> whole project -> ok".

QuintinWillison avatar Oct 31 '22 13:10 QuintinWillison