Adam Black
Adam Black
Personally I think this would be better for a DatabaseConnector/SqlRender component in python. It's an interesting idea to bring it into R...
Hi @fdefalco, Is there any timeline for when the PR will be reviewed? I can review and merge if you'd like.
Thanks for the update! It makes sense to ensure consistency (no change in output on all supported dbms) and performance on dbms other than spark. I think this could be...
I see there are tests that run with each push on several dbms. But I'm not sure if they actually run when someone makes a PR from a separate external...
I think type stability is an important principle for non-interactive R code. Functions in study packages should return a predictable type or fail. `[.data.frame` is not type stable. `sapply` is...
Here is one example of an issue that might arise. ``` r library(tibble) targetIds 1 5 #> 2 7 #> 3 8 #> 4 9 #> 5 10 ``` One...
Also had an error when running this on the ohdsi test postgres database.
No changes to Andromeda but I think dbplyr had a release recently so maybe that is the cause. I'll try to dig into it and post my findings.
Well I have not had much time to dig into why this is failing (lots to do 🚀 ) but I did download the current release and run the `devtools::test()`...
@anthonysena, @alex-odysseus, @chrisknoll - Who is responsible for reviewing this PR?