bunk

bunk copied to clipboard

* All public classes, interfaces, methods etc must be documented. * All method parameters and return types must be marked with `@NonNull` or `@Nullable`.

abhijitparida

Add a Cache.deleteStudent(username) method instead of using Cache.setStudent(username, null)

13

File location: [app/src/main/java/app/abhijit/iter/data/Cache.java](https://github.com/abhijitparida/bunk/blob/master/app/src/main/java/app/abhijit/iter/data/Cache.java) ~(update/add unit tests accordingly)~

abhijitparida

Update background color of the 'BUNK' button in LoginActivity, so that it is consistent with the theme colors

3

See: 1. [app/src/main/res/values/styles.xml](https://github.com/abhijitparida/bunk/blob/master/app/src/main/res/values/styles.xml) 2. [app/src/main/res/values/colors.xml](https://github.com/abhijitparida/bunk/blob/master/app/src/main/res/values/colors.xml)

abhijitparida

Add adaptive launcher icon

10

Source material: 1. https://github.com/abhijitparida/bunk/blob/master/promo/logo.svg 2. https://github.com/abhijitparida/bunk/blob/master/promo/playstore%20logo.png

abhijitparida

Some methods of the `Subject` model are not currently being unit tested. Add unit tests for all public methods. See: * [app/src/main/java/app/abhijit/iter/models/Subject.java](https://github.com/abhijitparida/bunk/blob/master/app/src/main/java/app/abhijit/iter/models/Subject.java) * [app/src/test/java/app/abhijit/iter/models/SubjectTest.java](https://github.com/abhijitparida/bunk/blob/master/app/src/test/java/app/abhijit/iter/models/SubjectTest.java)

abhijitparida

Make sure these boxes are checked before submitting your pull request. - [x ] My code follows the style guidelines of this project - [ x] New and existing unit...

svignesh93

Also, I added values in colors.xml "colorPrimary", "colorPrimaryDark", "colorAccent" I highly recommend you to use these values for setting up primary colors. Then you can change them accordingly. Signed-off-by: KRHero03...

KRHero03

Cookiejar tests

1

Make sure these boxes are checked before submitting your pull request. - [x] My code follows the style guidelines of this project - [x] New and existing unit tests pass...

pedroqueiroz

Make sure these boxes are checked before submitting your pull request. - [x] My code follows the style guidelines of this project - [x] New and existing unit tests pass...

siddheshr

Make sure these boxes are checked before submitting your pull request. - [x] My code follows the style guidelines of this project - [x] New and existing unit tests pass...

pedroqueiroz