llama-cpp-python icon indicating copy to clipboard operation
llama-cpp-python copied to clipboard
verified publisher icon abetlen

Update README.md

Open Nik-Kras opened this issue 1 year ago • 4 comments

Nik-Kras avatar Nov 08 '24 02:11 Nik-Kras

Average 'I can't code but I want to be in the contributors list' PR

ExtReMLapin avatar Nov 11 '24 20:11 ExtReMLapin

Hi @Nik-Kras, I think it's nice to keep the text clean. My suggestion is that I would probably go lighter on the changes and just stick to obvious grammar errors (The model will will format), and not just minor style changes. This is because the changes add extra diffs to the code which can make history harder to trace. If you stick to fixes it will also make it easier for the maintainer to merge.

I'm reminded of this first PR on a project I worked on, which got a bit famous with a blog post: https://github.com/playframework/playframework/pull/616. Hopefully that will encourage you.

richdougherty avatar Nov 24 '24 09:11 richdougherty

readme > llm > PR

devashishraj avatar Feb 04 '25 14:02 devashishraj

@ExtReMLapin This kind of hostility to new contributors to a project is never appropriate.

jroper avatar Sep 19 '25 01:09 jroper