types-lxml icon indicating copy to clipboard operation
types-lxml copied to clipboard

Add mypy.stubtest

Open macro1 opened this issue 11 months ago • 2 comments

This adds running mypy.stubtest along side the pytest tests that are being run. It can be helpful in comparing typed interfaces with runtime as well as providing context for missing stubs.

The allowlist in this PR represents the list of technically missing or deviating variables or modules. Some may be intentional or desirable, but in other cases it could point to gaps in the project.

macro1 avatar May 02 '25 04:05 macro1

Thanks, this can come in handy. However, although most errors emitted by mypy.stubtest are dummy, I suspect there is genuine error hidden in between that needs fixing. So I'd like to have a review personally with all mypy.stubtest complaints, then merge this PR with a trimmed down allowlist. That could take some time, so will leave this PR open for a while when I'm working on it.

abelcheung avatar May 02 '25 07:05 abelcheung

sounds good!

On Fri, May 2, 2025, 12:31 AM Abel Cheung @.***> wrote:

abelcheung left a comment (abelcheung/types-lxml#92) https://github.com/abelcheung/types-lxml/pull/92#issuecomment-2846557869

Thanks, this can come in handy. However, although most errors emitted by mypy.stubtest are dummy, I suspect there is genuine error hidden in between that needs fixing. So I'd like to have a review personally with all mypy.stubtest complaints, then merge this PR with a trimmed down allowlist. That could take some time, so will leave this PR open for a while when I'm working on it.

— Reply to this email directly, view it on GitHub https://github.com/abelcheung/types-lxml/pull/92#issuecomment-2846557869, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPWJFA3OHV5FTGSCJTH7S324MNNXAVCNFSM6AAAAAB4JFV7MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBWGU2TOOBWHE . You are receiving this because you authored the thread.Message ID: @.***>

macro1 avatar May 02 '25 14:05 macro1