atom-figlet issues

Uncaught TypeError: editor.getCommentStrings is not a function

10

# Steps to reproduce: 1. Select text. 2. Run the convert action. 3. Select a font. The error is thrown immediately. I assume it's because APIs have changed in newer...

XanderXAJ

Uncaught TypeError: Cannot read property 'map' of undefined

[Enter steps to reproduce:] 1. ... 2. ... **Atom**: 1.37.0 x64 **Electron**: 4.1.4 **OS**: "Manjaro Linux" **Thrown From**: [figlet](https://github.com/abe33/atom-figlet) package 0.5.4 ### Stack Trace Uncaught TypeError: Cannot read property 'map'...

samyakbardiya

it not work

1

[Enter steps to reproduce:] 1. just run 2. ... **Atom**: 1.33.0 x64 **Electron**: 2.0.11 **OS**: Windows 10 **Thrown From**: [figlet](https://github.com/abe33/atom-figlet) package 0.5.4 ### Stack Trace Uncaught TypeError: editor.getCommentStrings is not...

lvtoo

Fix issues with `getCommentStrings` for Atom 1.23+

2

It now calls `editor.getScopedSettingsDelegate().getCommentStrings(scope)` if `getCommentStrings` doesn't exist. See: [hydrogen/pull/1093](https://github.com/nteract/hydrogen/pull/1093/files#diff-3e2fce8735e63ba9d764917e356179cc) I continued to use the slightly more verbose `?` operator because it seemed slightly better than a short circuit assignment...

danielhickman

Uncaught TypeError: Cannot read property 'index' of null

[Enter steps to reproduce:] 1. ... 2. ... **Atom**: 1.30.0 x64 **Electron**: 2.0.5 **OS**: Microsoft Windows 10 Pro **Thrown From**: [figlet](https://github.com/abe33/atom-figlet) package 0.5.4 ### Stack Trace Uncaught TypeError: Cannot read...

bombadil7