Results 23 comments of karei

In short, we need to keep __eval_G_DETPFlash consistent across overloads: ```julia __eval_G_DETPFlash(wrapper::PTFlashWrapper{

Hi, please take a look at the new test I added. I ran it locally and it failed. I noticed that the Gibbs free energy results for the case below...

Thank you for the clarification. The new Gibbs model being able to use second-order optimizers sounds very cool. Please consider merging this branch first. There are still some bugs in...

That is, the newly added test `@test flash0[3] ≈ flash_RR[3] rtol = 1e-12` should be run on the master branch, since only the master branch's `gammaphi_gibbs` function implements `g_ideal =...

**Additional case: `tp_flash` returns `NaN` *inside* (Tb, Td) even though bubble/dew are finite** I precomputed bubble and dew temperatures at the same pressure; both return finite values. I then picked...

Thanks a lot for the quick reply! 1. I pulled and installed `master`. Calling `crit_mix(mix, n)` no longer errors—great! But I now get `(6.737593278553103, 190.50721203516426, 1.0160744078375186)`. If I’m reading this...

Hello longemen3000, I've encountered a new challenging VLE problem that cannot be solved even with `suggest_K`. Could you please help me? ```julia #= The mix is the same as in...

> [@longemen3000](https://github.com/longemen3000) might have a better explanation, but, from what I can see, you're at the limit of machine precision with these conditions (1e-16). You are probably going to run...

Thank you Sush1090! I think I can use `mechanical_critical_point` instead of `crit_mix` now. So the critical point problem is solved.

I just tried it and got the same result as you. But since you say the formula is wrong, never mind. ```julia @time crit_mix(mix, n) # 0.000296 seconds (478 allocations:...