interface icon indicating copy to clipboard operation
interface copied to clipboard

Approval amount warning

Open defispartan opened this issue 2 years ago • 3 comments

Describe the bug

MetaMask has a feature which works like a bug for certain Aave interface actions. If you peerform an approval of aTokens with a transaction (withdrawing base tokens (goes through WETHGateway all other withdrawals don't need an approval), repay with collateral, collateral swap, or migration) when you go to submit the tx MetaMask will prompt you to update the amount.

If you select max (current balance) the next transaction trying to spend the full balance will fail because aToken balance is constantly increasing.

Need to decide if this warrants a message in these modals to prompt that the approved amount must be > current balance to spend all aTokens in a transaction.

To Reproduce

Perform an approval of aTokens with a transaction (repay with colalteral, collateral swap, or migration) when you go to submit the tx MetaMask will prompt you to update the amount.

If you select max (current balance) the next transaction trying to spend the full balance will fail because aToken balance is constantly increasing.

Expected behavior

User approves an amount > current balance and tx suceeds.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

defispartan avatar Apr 26 '23 23:04 defispartan

@defispartan can we close this because its been fixed?

Jdecristi avatar May 27 '23 01:05 Jdecristi

ug im getting withdrawal issue for no reason with metamask, spending the whole day trying to figure this out - i don't like aaeve and have these issues often, i have less issues with compound

sbarbarino22 avatar Jul 20 '24 09:07 sbarbarino22