git-stalk-cli icon indicating copy to clipboard operation
git-stalk-cli copied to clipboard
verified publisher icon aashutoshrathi

Remove Today from default format and insert date instead

Open aashutoshrathi opened this issue 7 years ago • 4 comments

Default format of output in console contains Today which is now irrelevant as we provide date arguements

aashutoshrathi avatar Oct 14 '18 11:10 aashutoshrathi

@aashutoshranthi please provide some description. I wanna do this task.

ammarmallik avatar Oct 14 '18 12:10 ammarmallik

@ammarmallik, The printed output is hard coded to say things such as: {} have made {} public contribution(s) today. line 141 {} have done {} other public activit(y/ies) today. line 157 {} have starred {} repo(s) today. line 176

The logic has been modified with the addition of --date parameter, so these print statements need to reflect the date value (args['date']) which should be passed into the function calls between lines 298 and 307.

Hopefully that clarifies it a little more

GenericStudent avatar Oct 14 '18 14:10 GenericStudent

Yes, Thanks. I'll make a pull request with its fix.

ammarmallik avatar Oct 14 '18 14:10 ammarmallik

I have completed the dev work. Please merge this pull request #31 before applying these changes. This is the pull request #44.

ammarmallik avatar Oct 14 '18 16:10 ammarmallik