AaronStatic_modules icon indicating copy to clipboard operation
AaronStatic_modules copied to clipboard

Warnings observed while building Cardinal

Open cosinekitty opened this issue 1 year ago • 0 comments

I'm submitting this issue in the spirit of helpfulness as a fellow developer, not because the warnings are causing me any problems. I hope this might improve code quality.

This morning I was building Cardinal as part of submitting my own PR there, and I saw these warnings. A couple of the snprintf warnings indicate possible memory corruption.

Compiling AaronStatic/src/ChordCV.cpp
AaronStatic/src/ChordCV.cpp: In member function ‘virtual void ChordCVWidget::ChordDisplayWidget::drawLayer(const rack::widget::Widget::DrawArgs&, int)’:
AaronStatic/src/ChordCV.cpp:134:82: warning: ‘snprintf’ output truncated before the last format character [-Wformat-truncation=]
  134 |                                                 snprintf(text, 13, "             ");
      |                                                                                  ^
AaronStatic/src/ChordCV.cpp:134:57: note: ‘snprintf’ output 14 bytes into a destination of size 13
  134 |                                                 snprintf(text, 13, "             ");
      |                                                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
Compiling AaronStatic/src/DiatonicCV.cpp
AaronStatic/src/DiatonicCV.cpp: In member function ‘virtual void DiatonicCVWidget::ChordDisplayWidget::drawLayer(const rack::widget::Widget::DrawArgs&, int)’:
AaronStatic/src/DiatonicCV.cpp:172:82: warning: ‘snprintf’ output truncated before the last format character [-Wformat-truncation=]
  172 |                                                 snprintf(text, 13, "             ");
      |                                                                                  ^
AaronStatic/src/DiatonicCV.cpp:172:57: note: ‘snprintf’ output 14 bytes into a destination of size 13
  172 |                                                 snprintf(text, 13, "             ");
      |                                                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
Compiling AaronStatic/src/musiclib.cpp
Compiling AaronStatic/src/plugin.cpp
Compiling AaronStatic/src/RandomNoteCV.cpp
AaronStatic/src/RandomNoteCV.cpp: In member function ‘virtual void RandomNoteCVWidget::NoteDisplayWidget::drawLayer(const rack::widget::Widget::DrawArgs&, int)’:
AaronStatic/src/RandomNoteCV.cpp:145:69: warning: ‘snprintf’ output truncated before the last format character [-Wformat-truncation=]
  145 |                                                 snprintf(text, 1, " ");
      |                                                                     ^
AaronStatic/src/RandomNoteCV.cpp:145:57: note: ‘snprintf’ output 2 bytes into a destination of size 1
  145 |                                                 snprintf(text, 1, " ");
      |                                                 ~~~~~~~~^~~~~~~~~~~~~~
Compiling AaronStatic/src/ScaleCV.cpp
AaronStatic/src/ScaleCV.cpp: In member function ‘virtual void ScaleCVWidget::ChordDisplayWidget::drawLayer(const rack::widget::Widget::DrawArgs&, int)’:
AaronStatic/src/ScaleCV.cpp:125:82: warning: ‘snprintf’ output truncated before the last format character [-Wformat-truncation=]
  125 |                                                 snprintf(text, 13, "             ");
      |                                                                                  ^
AaronStatic/src/ScaleCV.cpp:125:57: note: ‘snprintf’ output 14 bytes into a destination of size 13
  125 |                                                 snprintf(text, 13, "             ");
      |                                                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

cosinekitty avatar Apr 01 '24 16:04 cosinekitty