aarondcoleman
Support Sleep API Endpoint v1.2
Hot off the presses: https://dev.fitbit.com/docs/sleep/#version-1-2
Would be great to get this endpoint implemented! Needs:
- JSON example
- Unit Tests
- FitbitClient method & parser.
I can take a look at starting this per https://twitter.com/aaronc/status/864336470957408256
Happy to review PR when ready. Any questions just shout :-) (I don't have access to a computer at the moment but can read the pr :-))
Hey just a status update, i have most of the api calls done and working on unit testing now, i havent pushed any changes on my fork in the recent week or so but im aiming to have a pr open next week at some time.
great! if you have updates @amammay and want to just have us look at specific commits, that's fine too. Just post the URL.
Hi @amammay. Any progress on this, or is it abandoned? We'd be happy to pick up on progress if so. Would love to see it included and released in the next week or so!
@aarondcoleman yea, i had most of the api endpoints finished up and not pushed but lost my progress when i reformatted my drive, been trying to catch back up to my progress, i do have a question about deprecated sleep endpoint, i have just given the v1 function call the obsolete attribute and moved its models into a deprecated folder for the time being. What would you like done with the models?
Great, thanks.
V1 endpoint shouldn't be touched. It will be supported for a long time and we for example have long term customer contracts that depend on it.
Lemme know if there are any other Q's!
--Aaron
On Tue, Jun 20, 2017 at 7:59 PM Alex Mammay [email protected] wrote:
@aarondcoleman https://github.com/aarondcoleman yea, i had most of the api endpoints finished up and not pushed but lost my progress when i reformatted my drive, been trying to catch back up to my progress, i do have a question about deprecated sleep endpoint, i have just given the v1 function call the obsolete attribute and moved its models into a deprecated folder for the time being. What would you like done with the models?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/aarondcoleman/Fitbit.NET/issues/203#issuecomment-309932593, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ1CaptgrfU25ZWOKZNmGN850aB1_uZks5sGGrcgaJpZM4MzakC .
-- Founder & CEO Fitabase by Small Steps Labs LLC @aaronc
@aarondcoleman ok i should have the pull request open by sunday, going to crank out my unit testing and clean up tomorrow.
@aarondcoleman @WestDiscGolf i have done the REST Get calls so far, before i implement the delete, put calls can you take a quick look at https://github.com/amammay/Fitbit.NET/tree/SleepAPI to make sure im heading in the right direction so far?
@amammay -- cool, thanks for coming up for air and checking in. I left you 2 comments in place on some of your latest commits.
- https://github.com/amammay/Fitbit.NET/commit/d98636e68afad3bc0a9633870e3d17edf59b7dd3#commitcomment-22773824
- https://github.com/amammay/Fitbit.NET/commit/d98636e68afad3bc0a9633870e3d17edf59b7dd3#commitcomment-22773607
@aarondcoleman @dwaynefitabase is it alright if i finish up the unit testing in regards to the sleep items on a new branch?
Sure, sounds good.
Founder & CEO Fitabase by Small Steps Labs LLC @aaronc
On Wed, Jul 12, 2017 at 4:20 PM, Alex Mammay [email protected] wrote:
@aarondcoleman https://github.com/aarondcoleman @dwaynefitabase https://github.com/dwaynefitabase is it alright if i finish up the unit testing in regards to the sleep items on a new branch?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aarondcoleman/Fitbit.NET/issues/203#issuecomment-314925092, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ1CViTfTpxth718KmdKfbh6Aq_9LmKks5sNVTVgaJpZM4MzakC .