CaveView.js icon indicating copy to clipboard operation
CaveView.js copied to clipboard

v2.4.0 don't work on PaleMoon browser

Open damjang opened this issue 4 years ago • 1 comments

I have updated CV from 2.1.3 to 2.4.0, but the last one don't work on my browser (PaleMoon -> http://www.palemoon.org/ ) but work on Chrome, Firefox and Edge. The previously installed version work ok also on my browser. If I check the Error Console I see this error

Error: SyntaxError: bad method definition
Source File: http://www.grmada.org/CV/CaveView/js/CaveView2.js
Line: 30556, Column: 2
Source Code:
  isLineSegmentsGeometry = true; 

Can this be checked and corrected if possible? You can use the portable version of PaleMoon to check (e.g. http://www.palemoon.org/download.php?mirror=eu&bits=64&type=portable ), maybe use my test page here: http://www.grmada.org/CV/

And another note, I have checked all in win7.

Thank you!

damjang avatar Nov 20 '21 22:11 damjang

I post the problem on PaleMoon forum and got response from author: CaveView tries to use a class field inside a class. This isn't currently supported by us and it should be put inside the class constructor, otherwise it will be seen as a class method definition (resulting in the error seen). see more here: https://forum.palemoon.org/viewtopic.php?f=70&t=27612

I try to correct as specified, but more errors with same "bad method definition" come out. Then also some other errors, e.g. if ( ! ( ( node.ownType ?? node.type ) & STATION_ENTRANCE ) ) return; or if ( entranceInfo?.name !== undefined ) { and if ( surveyColourMap?.[ id ] !== undefined ) { but I'm unable to fix this.

damjang avatar Nov 22 '21 22:11 damjang