wp-cli-login-command icon indicating copy to clipboard operation
wp-cli-login-command copied to clipboard
verified publisher icon aaemnnosttv

Add support for url prefix

Open oxyc opened this issue 1 year ago • 2 comments

See https://github.com/aaemnnosttv/wp-cli-login-command/issues/10#issuecomment-2260821596 Just opening this up for discussion but this might not be the best way since at a glance you might expect the prefix to be validated which it's not. Any thoughts or not looking to add support for this?

oxyc avatar Jul 31 '24 16:07 oxyc

Hey, thanks for the PR. This looks like a safe change to make which is also backwards compatible. Is there a reason why it would be preferable to add this with a filter rather than an an argument to the command?

aaemnnosttv avatar Aug 17 '24 15:08 aaemnnosttv

Not at all, a command line flag would work just as well. I changed the PR.

Note, I didn't run the tests (yet) as I didn't have a local environment set up for behat.

oxyc avatar Aug 17 '24 16:08 oxyc