Grant Forrest

Results 111 comments of Grant Forrest

Oof, first client-side only recipe page. Will need to use puppeteer to do this...

Ingredient converter could just be a button on the line For instructions it may require more effort / use of inline mark magic. But still probably useful for things like...

Colors should be dynamic based on the content we're mocking out. Here's a trick I learned with border-color: https://codesandbox.io/s/vy33pom0l0

Seems like it comes from Downshift. Might need to look into why they apply that.

The way Fields lays out children is pretty dependent on whether those children have labels / helptext, which complicates things. Basically, Fields has to coordinate its layout to vertically align...

I think we could just omit sending `disabled` to the underlying HTML element. Using a `disabled` prop still makes sense for the `Link` component contract since passing `disabled` will also...

With styled-components I'm not sure a classname is necessary, since we can just pass it in as a prop to do conditional styling (styled-components internally will generate a new classname...

Huh, good call. The grid system may be a little inflexible. Honestly, it's a bit hacked anyway... it's been hard to come up with a good, stable solution for vertically-aligned...

Nesting `` elements (if that's what you're talking about) is explicitly called out as unsupported in the HTML5 draft: https://www.w3.org/TR/html5/forms.html#the-form-element But the library's `Form` element in general is pretty bad...

I personally think the Address use case is more correctly modeled using multiple adjacent Field.Group blocks. ``` {/* ... */} {/* ... */} ``` This doesn't work well right now...